This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: strip control characters from user output#3420
Merged
achingbrain merged 3 commits intomasterfrom Nov 25, 2020
Merged
Conversation
Removes control characters (e.g. char code < 32) from any fields printed by the CLI that could have once have been user input. For `jsipfs dag get` it attempts to strip control characters from dag-pb and dag-cbor nodes and escapes them from everything else. raw nodes get blurted into the terminal the same as if you'd done `jsipfs cat ...`
jacobheun
approved these changes
Nov 24, 2020
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
minor jsdoc comment issues otherwise this looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes control characters (e.g. char code < 32 or 127 (DEL)) from any fields printed by the CLI that could have once have been user input.
For
jsipfs dag getit attempts to strip control characters from dag-pb and dag-cbor nodes and escapes them from everything else.raw nodes get blurted into the terminal the same as if you'd done
jsipfs cat ...Also brings the output of
jsipfs dag getmore into line with go-ipfs and allows specifying which encoding to display data fields in.